gh-148762: speed up SRE_AT_BEGINNING_LINE regexes#148778
Open
haampie wants to merge 1 commit intopython:mainfrom
Open
gh-148762: speed up SRE_AT_BEGINNING_LINE regexes#148778haampie wants to merge 1 commit intopython:mainfrom
haampie wants to merge 1 commit intopython:mainfrom
Conversation
Signed-off-by: Harmen Stoppels <harmenstoppels@gmail.com>
haampie
force-pushed
the
hs/fix/multiline-caret
branch
from
a59b863 to
22f498f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SRE(search)lacks a fast-forward for multiline regexes likeeven though it has a fast prefix scan for regexes like
foo.The current implementation does a character-by-character loop that calls
SRE(match)each iteration, leading to a lot of overhead.This commit ensures
SRE(match)is only called right after a newlinecharacter, leading to a ~10x speedup in a representative benchmark.
^. #148762