gh-142965: Fix Concatenate documentation to reflect valid use cases#143316
Merged
JelleZijlstra merged 2 commits intopython:mainfrom Apr 23, 2026
Merged
gh-142965: Fix Concatenate documentation to reflect valid use cases#143316JelleZijlstra merged 2 commits intopython:mainfrom
JelleZijlstra merged 2 commits intopython:mainfrom
Conversation
…ases The documentation previously stated that Concatenate is only valid when used as the first argument to Callable, but according to PEP 612, it can also be used when instantiating user-defined generic classes with ParamSpec parameters.
|
All commit authors signed the Contributor License Agreement. |
JelleZijlstra
added
needs backport to 3.13
|
Thanks @sandole for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
|
GH-148899 is a backport of this pull request to the 3.14 branch. |
|
GH-148900 is a backport of this pull request to the 3.13 branch. |
JelleZijlstra
pushed a commit
that referenced
this pull request
Apr 23, 2026
…cases (GH-143316) (#148900) The documentation previously stated that Concatenate is only valid when used as the first argument to Callable, but according to PEP 612, it can also be used when instantiating user-defined generic classes with ParamSpec parameters. (cherry picked from commit 75ff1af) Co-authored-by: John Seong <39040639+sandole@users.noreply.github.com>
JelleZijlstra
pushed a commit
that referenced
this pull request
Apr 23, 2026
…cases (GH-143316) (#148899) The documentation previously stated that Concatenate is only valid when used as the first argument to Callable, but according to PEP 612, it can also be used when instantiating user-defined generic classes with ParamSpec parameters. (cherry picked from commit 75ff1af) Co-authored-by: John Seong <39040639+sandole@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typing.Concatenatethat claimed it is only valid as the first argument toCallableConcatenatecan also be used when instantiating user-defined generic classes withParamSpecparameters, as specified in PEP 612Test plan
Fixes #142965
typing.Concatenate#142965📚 Documentation preview 📚: https://cpython-previews--143316.org.readthedocs.build/