Skip to content

Emit each missing setting warning only once #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zware merged 1 commit into from
Oct 21, 2026
Merged

Emit each missing setting warning only once #821

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions master/custom/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@
)


_WARNINGS = {*()}


class Settings:

value = ...
Expand Down Expand Up @@ -66,10 +69,12 @@ def get(self, key, default=...):
def _convert(self, func, default):
if self.value is not ...:
return func(self.value)
default = DEFAULTS.get(".".join(map(str, self.path)), default)
if not os.getenv("CI"):
path = ".".join(map(str, self.path))
default = DEFAULTS.get(path, default)
if not os.getenv('CI') and path not in _WARNINGS:
# Note: We use log.err to make this show up during `checkconfig`
log.err(f"WARNING: No setting at {self.path}, returning {default}")
log.err(f"WARNING: No setting at {path}, returning {default}")
_WARNINGS.add(path)
return func(default)

def __int__(self):
Expand Down
Loading