docs: add bootstrapper architecture overview#1250
Conversation
|
Warning Review limit reached
Next review available in: 58 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughAdds architecture documentation for Fromager’s subsystems, bootstrapper phase pipeline, resolver/provider behavior, layered package settings, and hooks or overrides. The concepts index now links the new pages, while Estimated code review effort: 2 (Simple) | ~15 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/concepts/bootstrapper-architecture.rst`:
- Around line 1-6: Add a Sphinx `.. versionadded::` directive near the beginning
of the Bootstrapper Architecture document, using the release version that
introduced this new user-facing documentation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 8cfd8523-ddb0-4830-af89-cd2473a0ddc7
📒 Files selected for processing (3)
AGENTS.mddocs/concepts/bootstrapper-architecture.rstdocs/concepts/index.rst
LalatenduMohanty
force-pushed
the
docs/bootstrapper-architecture
branch
from
129b2c1 to
8fed1d7
Compare
LalatenduMohanty
force-pushed
the
docs/bootstrapper-architecture
branch
from
8fed1d7 to
47622cc
Compare
Also add an AGENTS.md rule to keep the docs in sync when the architecture changes. Closes: python-wheel-build#1247 Co-Authored-By: Claude <claude@anthropic.com> Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
LalatenduMohanty
force-pushed
the
docs/bootstrapper-architecture
branch
from
47622cc to
f2a037c
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/concepts/index.rst`:
- Line 16: Update the Package Settings entry in the documentation to render the
PackageBuildInfo class name with reStructuredText inline code markup using
double backticks, while leaving the surrounding description unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 255e70a9-158c-4ad8-9a07-9a73317de426
📒 Files selected for processing (7)
AGENTS.mddocs/concepts/architecture-overview.rstdocs/concepts/bootstrapper-architecture.rstdocs/concepts/hooks-and-overrides.rstdocs/concepts/index.rstdocs/concepts/package-settings.rstdocs/concepts/resolver-architecture.rst
✅ Files skipped from review due to trivial changes (5)
- docs/concepts/bootstrapper-architecture.rst
- docs/concepts/architecture-overview.rst
- AGENTS.md
- docs/concepts/package-settings.rst
- docs/concepts/resolver-architecture.rst
| * **Bootstrapper Architecture** - Phase pipeline, class hierarchy, and interaction model of the bootstrap engine | ||
| * **Resolver Architecture** - Resolution strategies, provider hierarchy, version filtering, and per-package configuration | ||
| * **Hooks and Overrides** - The two plugin systems: per-package overrides and global hooks | ||
| * **Package Settings** - Settings loading, merge order, and the PackageBuildInfo facade |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Use reStructuredText code markup for PackageBuildInfo.
Render the class name as PackageBuildInfo. As per coding guidelines, docs/**/*.rst requires double backticks around function and class names.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/concepts/index.rst` at line 16, Update the Package Settings entry in the
documentation to render the PackageBuildInfo class name with reStructuredText
inline code markup using double backticks, while leaving the surrounding
description unchanged.
Source: Coding guidelines
1 participant
Add architecture overview docs
Also add an AGENTS.md rule to keep the docs in sync when the architecture changes.
Closes: #1247