refactor(bootstrapper): apply review follow-ups to _cache module#1248
Open
dhellmann wants to merge 1 commit into
Open
refactor(bootstrapper): apply review follow-ups to _cache module#1248dhellmann wants to merge 1 commit into
dhellmann wants to merge 1 commit into
Conversation
Add docstring to `Bootstrapper` class describing it as an iterative DFS engine to be used as a context manager. Rename private `_cache` functions that cross module boundaries to drop the leading underscore, reflecting their role as internal-but-public APIs within the bootstrapper package: - `_find_cached_wheel` → `find_cached_wheel` - `_bg_prepare_prebuilt` → `bg_prepare_prebuilt` Update all call sites in `_bootstrapper.py`, `_prepare_source.py`, `_resolve.py`, and tests. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
📝 WalkthroughWalkthroughThe cache helpers Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add docstring to
Bootstrapperclass describing it as an iterative DFS engine to be used as a context manager.Rename private
_cachefunctions that cross module boundaries to drop the leading underscore, reflecting their role as internal-but-public APIs within the bootstrapper package:_find_cached_wheel→find_cached_wheel_bg_prepare_prebuilt→bg_prepare_prebuiltUpdate all call sites in
_bootstrapper.py,_prepare_source.py,_resolve.py, and tests.