Conversation
Member
|
Hello, could you clarify how this PR accounts for my spec of what needs to be done to solve the issue. It seems that you've only solved a small subset. If everything else is actually OK, can you provide the evidence? It seems that you've just thrown an AI at the problem without understanding it, not even noticing that someone else had made the same mistake before you. This is a lack of respect. Please just don't throw an AI at my comment; I have an AI, and I'd rather run it myself than through you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve existing percent escapes in paths and queries when converting IRIs to URIs, as specified by RFC 3987 §3.1.
For example,
ws://example.com/a%20b?q=écurrently requests/a%2520b?q=%C3%A9instead of/a%20b?q=%C3%A9. Adding%to the safe set prevents this second encoding while retaining UTF-8 conversion of Unicode characters.Adds regressions for Unicode in the hostname, path and query with existing escapes, plus a changelog entry.
Validation: full suite passed on Python 3.11 and 3.14 (2,585 tests each); URI/client tests passed on 3.12, 3.13 and 3.15. Ruff, strict mypy, Sphinx, package build and Twine checks passed. URI coverage is 100%; overall coverage is 99% with the same seven unexecuted legacy lines on pristine main.