Conversation
add_line with a comment left the array in compact rendering, so the trailing # comment ran into the final ]. Insert a newline before that bracket so the result is valid TOML.
Author
|
Closing this — I missed the existing PRs already covering #580. Sorry for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #580
Array.add_line(..., comment=...)builds a compact array. The last item is a#comment with an empty trail, soas_string()glued the closing]onto that comment:That is not valid TOML. If the last compact item is a comment without a newline, a newline is inserted before
]. The existingadd_linetests that already end with a newline are unchanged.Agent Drafting Metadata
Tests