reject a comment containing line breaks in Item.comment and add_line#544
Merged
frostming merged 1 commit intoJul 14, 2026
Merged
Conversation
Contributor
Author
|
any update? |
Contributor
|
They are different thing, |
8eacf5b to
624bb4c
Compare
Contributor
Author
|
Makes sense, reworked it that way:
Updated the title and description to match. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Item.comment()andArray.add_line(comment=...)accepted a comment containing an embedded newline and rendered everything after the first line without a#, so the output no longer re-parses (tomlkit andtomllibboth reject it).ValueErrorup front instead of being reformatted; the item is left unmodified when it raises.Agent Drafting Metadata