fix(commands): support unquoted subcommands in help command (#258) - #545
Open
DYNOSuprovo wants to merge 1 commit into
Open
DYNOSuprovo wants to merge 1 commit into
DYNOSuprovo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #258
Description
Currently, running
<app> help <subcommand> <action>(such aspoetry help env use) fails withThe command "env" does not existunless the subcommand arguments are quoted (e.g.poetry help "env use").This happens because
HelpCommanddefinedcommand_namewithis_list=False. When multiple subcommand tokens are passed,ArgvInputassigns only the first token tocommand_nameand ignores subsequent tokens due toignore_validation_errors(), causingApplication.find()to fail to resolve the command.Changes
HelpCommand.argumentsto definecommand_namewithis_list=Trueanddefault=["help"].HelpCommand.handle(), joincommand_nametokens with spaces if a list is received before finding the command in the application.application_run5.txtfixture to match the updated synopsis formatting for list arguments ([<command_name>...]anddefault: ["help"]).test_run_help_with_nested_subcommandintests/test_application.pyasserting that unquoted subcommand help (help foo bar bazand--help foo bar baz) resolves correctly and matches quoted help (help "foo bar baz").news/258.bugfix.md.