Optimize histogram generation + fix masked histograms for 2-band images + add test coverage - #10005
Merged
Merged
Conversation
Same fix as dc7d646 but applied in the other code path too.
Merging this PR will improve performance by 66.4%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | test_histogram_masked[1237x811-L] |
13.3 ms | 7.1 ms | +88.85% |
| ⚡ | test_histogram_masked[1237x811-LA] |
21.4 ms | 14.6 ms | +46.62% |
Tip
Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.
Comparing akx:histo-opt (349c6ca) with main (26ddd05)
Footnotes
-
338 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
akx
marked this pull request as ready for review
September 16, 2026 07:30
radarhere
reviewed
Sep 16, 2026
radarhere
reviewed
Sep 17, 2026
radarhere
reviewed
Sep 17, 2026
radarhere
reviewed
Sep 17, 2026
radarhere
reviewed
Sep 17, 2026
radarhere
reviewed
Sep 17, 2026
radarhere
reviewed
Sep 17, 2026
radarhere
approved these changes
Sep 17, 2026
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
radarhere
enabled auto-merge
September 17, 2026 05:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows up on #9050
Follows up on #9054
Follows up on #9752 (comment)
This applies similar hoist/restrict optimizations as the earlier optimization PRs.
While doing that, I noticed the masked/non-masked loops were curiously different, and it looks like #9054 was never applied to the masked case.
I also noticed the masked path for histograms didn't have actual test coverage (they were incidentally covered by e.g.
autocontrast), so now they do.