Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment, when creating a raw ImagePalette with an RGB rawmode,
Oh, I'll have to do something so that this 'raw palette data' can be decoded into... wait a minute.
The rawmode and mode are the same! Who needs to decode anything?
ImagePalette.raw()creates an ImagePalette in an RGB mode.Pillow/src/PIL/ImagePalette.py
Lines 234 to 235 in 7e57b6c
Pillow/src/PIL/ImagePalette.py
Lines 46 to 48 in 7e57b6c
If the
rawmodeis also in RGB mode, then instead of settingrawmodeon the palette and potentially raising an error later, let's simply not setrawmode.