Repository navigation
Fix diff() typing to accept DateTime (closes #823) - #1087
Open
zheng-guannan577 wants to merge 1 commit into
Open
zheng-guannan577 wants to merge 1 commit into
zheng-guannan577 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #823: #823
Typing gap
DateTime.diff()previously declared its parameter asdatetime.datetime | None. Passing a PendulumDateTime(the library's own datetime type, and the typediff()is documented to compare) could therefore be flagged by type checkers/linters, even though it works at runtime.Change
In
src/pendulum/datetime.pyonly, widen the parameter type to:This is a typing-only change. No runtime logic, no other files, and no behaviour change.
Verification (honest note)
Full repo pytest was NOT run locally, because local 3.3.0 needs a Rust extension built with cargo which is not installed. No local test run is claimed beyond the GitHub web editor view; CI must verify the full test suite and typing.