Repository navigation
Conversation
range() treated amount as both the step and the termination increment with no validation, so amount=0 yielded the start forever and a mismatched sign walked away from the end. Reject a zero amount with ValueError. A negative amount whose sign does not match the interval direction now yields an empty iterator, matching Python range().
Muguett-DBY
reviewed
Nov 5, 2026
| ``` | ||
|
|
||
| `amount` must be a non-zero integer. A zero amount raises `ValueError`. | ||
| A negative amount whose sign does not match the interval direction |
There was a problem hiding this comment.
Could we clarify this for inverted intervals? If dt2 is later than dt1, interval(dt2, dt1).range("days", -1) returns an empty iterator even though the step points in the same direction as the interval. A positive amount already iterates backwards there.
For equal endpoints, the loop yields that endpoint once even with -1. A short example for each case would make the intended behavior clearer.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Fixes #1080
Interval.range(unit, amount)usedamountas both the step and the loop increment with no validation.amount=0therefore yielded the start forever (start.add(days=0)never moves, sostart <= endstays true). A negative amount on a forward interval walked away from the end instead of terminating.Reject a zero amount with
ValueError. A negative amount whose sign does not match the interval direction now yields an empty iterator, the same way Python'srange()does. Existing positive-amount ranges are unchanged.