Repository navigation
fix: GMX create-calendar is capped, not fragile - #854
Merged
Merged
Conversation
Where no calendar could be created (Posteo, GMX and other servers with create-calendar unsupported or fragile, or a refused MKCALENDAR with no cal_id given), the test fixtures fell back to the first calendar the server listed, and the tests then wiped it - possibly the user's own. Only a calendar at the fixture's cal_id, one with "pythoncaldav-test" in its display name or the one configured under test-calendar is used now; otherwise the tests needing a calendar skip, saying how to opt in. Prompt: [pick from the task list: "Stop integration tests from wiping a borrowed calendar without explicit opt-in"] Assisted-By: Claude Opus 5.5 <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
The GMX create-calendar hint said fragile because one test run failed every MKCALENDAR and the next one passed. Probing on 2026-11-10 showed a fixed cap: five calendars per account, the birthday calendar included, and a 403 beyond that, from either starting count tried. Calendars leaked by test runs explain the earlier failures. The hint is now full, with the cap in its behaviour text. Prompt: regarding the gmx mkcalendar marked as fragile, I vaguely remember it was fragile as in "try again"? Followup-Prompt: it could also be fragile like in "the quota of calendars you're allowed to have is 5" Followup-Prompt: ... fix the behavior [and] documentation ... Assisted-By: Claude Opus 5.5 <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
Xandikos answers a write with 423 while its git index.lock is held by another write, and a retry after a short sleep succeeds. The design now counts 423 as a class (C) status, opt-in via status_forcelist, asks whether it should be retried by default (Q7), and adds a section (4.6) on the immediate PUT retry in _post_put, which should leave class (C) statuses alone. Prompt: (traceback from plann's panic postponement pasted, ending in "PutError at '423 Locked'" from caldav's _post_put) Followup-Prompt: I think we have a github issue and some design document on "retry logic in the caldav library". Please find and add the 423-retry into the same design document. Fix the try-and-continue in plann. [the plann fix went into the plann repository] Followup-Prompt: the doc change should piggy-back another PR. If there are no other PRs in progress, then add a /calendar-task to get it pushed. [it went onto this PR] Assisted-By: Claude Opus 5.5 <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
The changelog fragment for the calendar-wipe fix still listed GMX among the servers where create-calendar is unsupported or fragile. GMX is now `full`, with a cap of five calendars, so the fragment names the cap. Prompt: [fix issues found during the review process] Assisted-By: Claude Opus 5.5 <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
tobixen
force-pushed
the
fix/gmx-calendar-cap
branch
from
November 11, 2026 06:33
b2d1b6d to
0d53fa4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit message: