Repository navigation
test: don't wipe a calendar not made for the tests - #853
Merged
Merged
Conversation
Where no calendar could be created (Posteo, GMX and other servers with create-calendar unsupported or fragile, or a refused MKCALENDAR with no cal_id given), the test fixtures fell back to the first calendar the server listed, and the tests then wiped it - possibly the user's own. Only a calendar at the fixture's cal_id, one with "pythoncaldav-test" in its display name or the one configured under test-calendar is used now; otherwise the tests needing a calendar skip, saying how to opt in. Prompt: [pick from the task list: "Stop integration tests from wiping a borrowed calendar without explicit opt-in"] Assisted-By: Claude Opus 5.5 <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
tobixen
force-pushed
the
fix/no-borrowed-calendar-wipe
branch
from
November 10, 2026 00:01
73d3367 to
c7f0b41
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit message:
test: don't wipe a calendar not made for the tests
Where no calendar could be created (Posteo, GMX and other servers with
create-calendar unsupported or fragile, or a refused MKCALENDAR with no
cal_id given), the test fixtures fell back to the first calendar the
server listed, and the tests then wiped it - possibly the user's own.
Only a calendar at the fixture's cal_id, one with "pythoncaldav-test"
in its display name or the one configured under test-calendar is used
now; otherwise the tests needing a calendar skip, saying how to opt in.
Prompt: [pick from the task list: "Stop integration tests from wiping a borrowed calendar without explicit opt-in"]
Assisted-By: Claude Opus 5.5 noreply@anthropic.com
Reviewed-by: Tobias Brox tobias@redpill-linpro.com
Also piggy-backing:
docs: note client_context() stopping foreign servers🤖 Generated with Claude Code