Skip to content

Fix RST markup of extract_javascript - #1431

Merged
akx merged 1 commit into
python-babel:masterfrom
tomasr8:docs-fix
Nov 5, 2026
Merged

akx merged 1 commit into
python-babel:masterfrom
tomasr8:docs-fix

Conversation

@tomasr8

@tomasr8 tomasr8 commented Nov 4, 2026

Copy link
Copy Markdown
Member

Before:

image

After:

image

I don't think there's a way to get the param description to render on the same line, but this is already a nice improvement ;)

Comment thread babel/messages/extract.py
* `parse_template_string` -- if `True` will parse the
contents of javascript
template strings.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This blank line is what makes the nested bullet list render properly

@codecov

codecov Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.66%. Comparing base (63c168e) to head (2b6f9db).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1431   +/-   ##
=======================================
  Coverage   93.66%   93.66%           
=======================================
  Files          27       27           
  Lines        4971     4971           
=======================================
  Hits         4656     4656           
  Misses        315      315           
Flag Coverage Δ
macos-14-3.10 92.69% <ø> (ø)
macos-14-3.11 92.63% <ø> (ø)
macos-14-3.12 92.89% <ø> (ø)
macos-14-3.13 92.89% <ø> (ø)
macos-14-3.14 92.87% <ø> (ø)
macos-14-3.15 92.87% <ø> (ø)
macos-14-3.8 92.57% <ø> (ø)
macos-14-3.9 92.63% <ø> (ø)
macos-14-pypy3.10 92.69% <ø> (ø)
ubuntu-24.04-3.10 92.71% <ø> (ø)
ubuntu-24.04-3.11 92.65% <ø> (ø)
ubuntu-24.04-3.12 92.91% <ø> (ø)
ubuntu-24.04-3.13 92.91% <ø> (ø)
ubuntu-24.04-3.14 92.89% <ø> (ø)
ubuntu-24.04-3.15 92.89% <ø> (ø)
ubuntu-24.04-3.8 92.59% <ø> (ø)
ubuntu-24.04-3.9 92.65% <ø> (ø)
ubuntu-24.04-pypy3.10 92.71% <ø> (ø)
windows-2022-3.10 92.71% <ø> (ø)
windows-2022-3.11 92.65% <ø> (ø)
windows-2022-3.12 92.91% <ø> (ø)
windows-2022-3.13 92.91% <ø> (ø)
windows-2022-3.14 92.89% <ø> (ø)
windows-2022-3.15 92.89% <ø> (ø)
windows-2022-3.8 92.68% <ø> (ø)
windows-2022-3.9 92.64% <ø> (ø)
windows-2022-pypy3.10 92.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed

codspeed Bot commented Nov 4, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 88 untouched benchmarks


Comparing tomasr8:docs-fix (2b6f9db) with master (63c168e)

Open in CodSpeed

@akx akx left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So many backticks!

@akx
akx merged commit 5471e67 into python-babel:master Nov 5, 2026
36 checks passed
@tomasr8
tomasr8 deleted the docs-fix branch November 5, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants