Repository navigation
Conversation
Add an opt-in update option for source spelling corrections whose translations remain valid. Keep existing fuzzy flags and plural-shape checks, and cover both the catalog API and PO file updates. Closes python-babel#1030
chrikrah
approved these changes
Nov 5, 2026
chrikrah
left a comment
Contributor
There was a problem hiding this comment.
@ada-wh525, reverting catalog.py:991 fails 5 of your 22 cases. Nothing here blocks a merge.
$ python -m pytest -q -p no:cacheprovider tests/messages # head 08d80b5, git archive export, babel.__file__ from the export, CLDR data from the 2.18.0 wheel, Python 3.12
1 failed, 468 passed # test_checkers.py::test_4_num_plurals_checkers, UnknownLocaleError from the older CLDR data, not this change
$ python -m pytest -q -p no:cacheprovider tests/messages -k no_fuzzy_flags
22 passed, 1 skipped, 443 deselected
$ sed -i '991s/fuzzy = not no_fuzzy_flags/fuzzy = True/' babel/messages/catalog.py # only the behavioural line reverted
$ python -m pytest -q -p no:cacheprovider tests/messages -k no_fuzzy_flags
5 failed, 17 passed, 1 skipped, 443 deselected
$ python3 -I -c "from difflib import SequenceMatcher as S; print(S(None, 'enable notifications', 'disable notifications', autojunk=False).ratio())"
0.878 # above get_close_matches cutoff=0.6, catalog.py:44
non-blocking: the flag is run-wide, so "Disable notifications" keeps "Enable" unflagged. Note that in cmdline.rst?
Author
Added a note in ba1aa84 to explain that. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating a source message to correct a spelling mistake currently marks its reused translation as fuzzy, even when the translation remains valid. Disabling fuzzy matching also prevents that translation from being reused.
Add
pybabel update --no-fuzzy-flagsand the correspondingCatalog.update(no_fuzzy_flags=True)option. This allows translations to be reused without adding a fuzzy flag solely because the message ID changed.Default behavior remains unchanged. Existing fuzzy flags and checks for changes to singular/plural structure are preserved.
Includes CLI documentation and tests covering singular/plural messages, contexts, existing flags, previous IDs, and PO file updates.
Validation:
Closes #1030