core: Add get_official_territories() - #1328
Open
ChrisJr404 wants to merge 1 commit into
Open
ChrisJr404 wants to merge 1 commit into
ChrisJr404 wants to merge 1 commit into
Conversation
akx
requested changes
Sep 18, 2026
akx
left a comment
akx
left a comment
Member
There was a problem hiding this comment.
A couple of territories the CLDR doesn't carry are missing, and a few exceptionally reserved codes like EU come along, so the docstring calls that out.
This seems unacceptable if the intent is to provide the official ISO 3166-1 territory list. If this were called get_cldr_territories(), that'd be much better already.
However, then I'd like that this was Refs #904, not fixes.
Comment on lines
+101
to
+104
| def _is_user_assigned_territory(code): | ||
| # ISO 3166-1 reserves these code ranges for private use, so they never | ||
| # denote an actual territory. | ||
| return code in ('AA', 'ZZ') or 'QM' <= code <= 'QZ' or 'XA' <= code <= 'XZ' |
Member
There was a problem hiding this comment.
Which ones of these appear in the CLDR, I'm curious?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #904.
Adds
get_official_territories()tobabel.core, returning a frozenset of the ISO 3166-1 alpha-2 territory codes. As mentioned in the issue, the data is pulled from the CLDR supplemental code mappings during the import, so it isn't a strict copy of the ISO list. I keep the two-letter codes that have a numeric ISO code, and drop the deprecated aliases and the user-assigned ranges, which lands on 250 codes.A couple of territories the CLDR doesn't carry are missing, and a few exceptionally reserved codes like EU come along, so the docstring calls that out.