Repository navigation
Structure heterogeneous tuples from iterable inputs - #814
Open
Gabrieljr42 wants to merge 1 commit into
Open
Gabrieljr42 wants to merge 1 commit into
Gabrieljr42 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heterogeneous tuples are documented to accept iterable inputs, but the generated structurer uses
len(o)ando[index]directly. For example,Converter().structure(iter(['1', 2]), tuple[int, str])raisesTypeErrorinstead of returning(1, '2').Materialize non-list/tuple iterables once before conversion. Keep list and tuple inputs without a copy, preserve exact-length validation in both validation modes, and let iteration exceptions propagate.
Add regression coverage for iterators, generators, empty tuples, short/long inputs, invalid element conversion, and iteration errors. The new regressions fail against the original generated implementation. Update HISTORY.md.
Validation with the locked dependencies on Python 3.14: the complete test suite passed (1,160 passed, 20 skipped, 15 expected failures). Ruff check and formatting checks passed. Implementation used a Luna agent followed by an independent review, reproduction against the original source, and the full test run.