Repository navigation
Support nullable tagged unions - #812
Open
Aschenbath wants to merge 1 commit into
Open
Aschenbath wants to merge 1 commit into
Aschenbath wants to merge 1 commit into
Conversation
Pass None through without generating a class hook. Register the union before generating its default member hook so recursive defaults keep the tagged handlers.
Aschenbath
marked this pull request as ready for review
October 25, 2026 01:36
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
configure_tagged_union(A | B | None, converter)currently attempts to generate a tag and class hooks forNoneType, so configuration fails. Support explicitly configured nullable unions by excludingNoneTypefrom the tag mapping and wrapping the existing hooks to passNonethrough unchanged. This also supportsA | Noneand PEP 695 aliases.Generate the default-member hook after registering the union hooks. Otherwise, a recursive default member can capture an untagged optional hook and reject a nested tag under
forbid_extra_keys=Truewhen the outer tag is missing or unknown. Custom tags, default members, strict validation, and input dictionaries retain their existing behavior for class values.Addresses #345, following the explicit nullable-union wrapper approach suggested in the issue. Callers configure the complete nullable type, including
None.Validation:
The full upstream CI workflow passes on this exact commit in the fork: all 10 jobs, covering CPython 3.10–3.15, PyPy 3.10, lint, package verification, and 100% combined coverage. The upstream Read the Docs build also passes.
Developed with AI assistance.