Skip to content

Test msgspec recursive passthrough and probe cleanup - #798

Open
Gabrieljr42 wants to merge 2 commits into
python-attrs:mainfrom
Gabrieljr42:fix/msgspec-recursive-attrs-hooks
Open

Gabrieljr42 wants to merge 2 commits into
python-attrs:mainfrom
Gabrieljr42:fix/msgspec-recursive-attrs-hooks

Conversation

@Gabrieljr42

@Gabrieljr42 Gabrieljr42 commented Oct 16, 2026 •

Copy link
Copy Markdown

The recursive msgspec hook fix has landed in #803. This PR now preserves that implementation and adds two complementary regression checks:

  • Recursive attrs classes without custom field hooks keep the msgspec passthrough path and serialize correctly.
  • An exception during hook probing does not leave stale probe state; a later hook lookup and conversion succeed.

Validation on Python 3.12: all 12 tests in tests/preconf/test_msgspec_cpython.py pass, and Ruff lint and formatting checks pass.

AI assistance was used to update the branch and prepare the tests.

@Gabrieljr42 Gabrieljr42 changed the title Fix recursive attrs hooks and private fields in msgspec Test msgspec recursive passthrough and probe cleanup Oct 25, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant