Adds type annotations to FixtureRequest.node - #15103
Open
Contrabang wants to merge 5 commits into
Open
Contrabang wants to merge 5 commits into
Contrabang wants to merge 5 commits into
Conversation
psf-chronographer
Bot
added
the
bot:chronographer:provided
for more information, see https://pre-commit.ci
Contrabang
marked this pull request as draft
September 25, 2026 22:22
Contrabang
marked this pull request as ready for review
September 25, 2026 23:44
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recommended reading: #7469 (comment)
Adds type annotations to FixtureRequest's node property. This type annotation is further narrowed down for the _pytest subclasses. This allows typecheckers like pyright to correctly determine node's type, where it would previously return "Unknown"
This alters the record_property for
junitxml.pyslightly, adding a cast of request.node toItemwhere theuser_propertiesvariable is defined. I couldn't find a way to restrict the types for the node property in a way to allow this without a cast.cast()has no performance impact, nor any assertions that stop the code from continuing. It simply tells the type checker what to expect. This will have functionally no impact on that function in production, as it would have errored when trying to accessUnknown.user_propertiesin cases wherenodeis notnodes.Item