Conversation
… errored Preserve exit statuses returned by fixture display commands and handle collection errors consistently with the main pytest execution path. Co-authored-by: ChatGPT <noreply@openai.com>
bluetech
approved these changes
Sep 17, 2026
bluetech
left a comment
Member
There was a problem hiding this comment.
Thanks, I made some tweaks but it should be good for pytest 10.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve the exit status returned by
showfixtures()andshow_fixtures_per_test()instead of unconditionally returning0frompytest_cmdline_main().Collection errors require additional handling because
Session.perform_collect()records them insession.testsfailedwithout raising. Extracted the existing collection-error check frompytest_runtestloop()into_raise_on_collection_errors()and reused it for the fixture display commands. With--continue-on-collection-errors, the commands now returnExitCode.TESTS_FAILEDwhen collection errors occurred.Added regression tests for both
--fixturesand--fixtures-per-test. Pre-fix:After the fix, collection errors return
ExitCode.INTERRUPTED(2), orExitCode.TESTS_FAILED(1) with--continue-on-collection-errors. Exit statuses produced by internal errors andpytest.exit()are also preserved instead of being replaced with0.Closes #15047.
closes #XYZWto the PR description and/or commits (whereXYZWis the issue number). See the [github docs](https://help.github.com/en/github/managing-work-on-github/managing-your-work-with-issues/linking-a-pull-request-to-an-issue) for more information.Co-authored-bycommit trailers.changelogdirectory, with a name like<ISSUE NUMBER>.<TYPE>.rst. See [changelog/README.rst](https://github.com/pytest-dev/pytest/blob/main/changelog/README.rst) for details.AUTHORSin alphabetical order.