Skip to content

fix: make non-base64 media paths relative to report location #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
decembercomposer697-hue wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −2
Open

fix: make non-base64 media paths relative to report location #1040

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/pytest_html/report.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,13 @@ def _media_content(self, content, asset_name, *args, **kwargs):
media_data = base64.b64decode(content.encode("utf-8"), validate=True)
return self._write_content(media_data, asset_name)
except binascii.Error:
# if not base64 content, just return as it's a file or link
return content
# if not base64 content, try to make it relative to the report
try:
abs_path = Path(content).resolve()
return str(abs_path.relative_to(self._report_path.parent.resolve()))
except (ValueError, OSError):
# On different drives (Windows) or unresolvable, return as-is
return content

def _write_content(self, content, asset_name):
content_relative_path = Path(self._assets_path, asset_name)
Expand Down