Repository navigation
Fix type compatibility for frame locals in Python 3.15+ - #282
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #282 +/- ##
=======================================
Coverage 97.84% 97.84%
=======================================
Files 17 17
Lines 927 927
Branches 55 55
=======================================
Hits 907 907
Misses 9 9
Partials 11 11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🟡 Changes recommended
The cast exposes a proxy object as a concrete dict, creating an inaccurate API contract.
1 open finding
What changed in this PR
Updates frame-local typing for Python 3.15 compatibility.
Changes:
- Casts
frame.f_localsto the existing return type. - Documents the Python 3.15 typing change.
| File | Description |
|---|---|
src/pytest_factoryboy/fixture.py |
Adjusts frame-local typing. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
frame.f_locals returns a FrameLocalsProxyType in Python 3.15+, which is not a dict subclass. Annotate get_caller_locals and the _caller_locals / inject_into_caller plumbing as MutableMapping to reflect the actual interface used, rather than asserting a concrete dict. Addresses review comment in #282.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.