Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #760. Distinct plugin objects that compare equal currently interfere with registration, lookup, and removal. Unregistering one can also remove the other's hook implementations.
Use identity for registration checks, name lookup, and hook removal. Subset callers key their exclusion map by object id, retaining object references to prevent id reuse. Blocked names remain distinct from registered plugins. The public set-returning get_plugins() API is unchanged.
Regression tests cover equal unhashable plugins with separate hooks, subset exclusions, unregistering only the intended object, duplicate-object rejection, an eq that raises, and blocked-name sentinels.
Validation (macOS / Python 3.12):
The committed lock resolves an old pytest/tox combination incompatible with Python 3.12. Tests used PYTHONPATH=src and uv --with overrides for pytest>=8, pytest-benchmark>=5, and tox>=4; no lock or dependency files were changed.
AI assistance: implementation and tests prepared with Codex, then reviewed against the reported case and hook lifecycle.