numba: inline="always" to speedup trivial op compilation#2111
Draft
ricardoV94 wants to merge 1 commit into
Draft
numba: inline="always" to speedup trivial op compilation#2111ricardoV94 wants to merge 1 commit into
ricardoV94 wants to merge 1 commit into
Conversation
ad5bc53 to
21c8e3b
Compare
21c8e3b to
60c0ae3
Compare
jessegrabowski
approved these changes
May 4, 2026
Member
|
nice and straight-forward. Win seems marginal but we take those. |
Member
Author
|
gotta wait, we had a big regression in scan... without #2098 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This speedups first time compilation. Numba prefers to compile a single function with may operations instead of our - one function per op - design. Added inline=always to trivial cheap Ops (scalar, dimshuffle, reshape, ...)
Note the speedup in compile with cache=False (False flag). With cache=True we are seeing the dominating effect of compiling something we already saw before, that isn't changed. But the first time compile should now be faster as well.