Repository navigation
Split the layers CI group and cut its redundant tests - #167
Merged
jessegrabowski merged 10 commits intoOct 2, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
layersgroup in therun_tests.ymltest matrix is now three groups,layers,recurrentandconvolution. The old group took 18 to 24 minutes per run.tests/test_recurrent.pyandtests/test_conv.pyalone accounted for 11 of its 20 minutes of test time.The six test files in those groups went from 245 tests to 147, and their cold run on 8 workers went from 54 s to 20 s. Most of the removed tests repeated a stronger reference comparison, or only asserted that a training loss fell.
_extract_patches,_scatter_patchesand_window_indicesare removed frompytensor_ml/layers/conv.py. They had no callers outside the tests that used them as a reference implementation.Coverage was added at the same time:
ConvLayerbias gradientIm2Col.performandCol2Im.performBefore this, none of these had a test that failed when it broke.
Recurrent._masked_stepnow zeroes masked inputs before the step. NaN in the padded positions made every parameter gradient NaN, even though the forward outputs stayed finite.Upsample2D(mode="bilinear")now returns its input's dtype. It built the interpolation weights atfloatX, so a float32 input came back as float64 under the default config.Closes #166
📚 Documentation preview 📚: https://pytensor-ml--167.org.readthedocs.build/en/167/