Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify when
X509.get_notBefore()andget_notAfter()returnNone: the underlying ASN.1 time is empty, as on a newly created X509 before setting its validity period. This does not mean certificate validity bounds are optional, andNoneis not a general indication of timestamp parsing failure.Fixes #1488. This is a docstring-only correction; runtime behavior is unchanged.
Validation: 8 existing notBefore/notAfter tests pass; Ruff check/format on the changed file and
sphinx-build -W -b htmlpass. A public-API probe also checked unset timestamps, valid loaded timestamps, and nonempty malformed GeneralizedTime bytes (returned as bytes rather thanNone). Full TLS tests and the backend/version matrix were not run.CI follow-up: the test/backend, downstream and documentation checks pass. Full-repository lint fails RUF012 on the preexisting
Connection._reverse_mappingdeclaration in unchangedsrc/OpenSSL/SSL.py:1936; localruff check .reproduces it. That file and the lint configuration are identical to the base.