feat(cmake): Use modern FetchContent approaches when available - #6081
Open
LecrisUT wants to merge 6 commits into
Open
feat(cmake): Use modern FetchContent approaches when available#6081LecrisUT wants to merge 6 commits into
LecrisUT wants to merge 6 commits into
Conversation
Author
|
A few follow-ups that I am interested:
|
LecrisUT
force-pushed
the
feat/fetchcontent
branch
6 times, most recently
from
June 3, 2026 16:53
2cfcab4 to
0c774fc
Compare
FetchContent lowercases the declared name, so the populated source directory is eigen3_SOURCE_DIR. EIGEN3_INCLUDE_DIR was set from the empty eigen_SOURCE_DIR, and the Eigen tests could not find Eigen/Core. Catch2 2.13.10 asks for compatibility with CMake < 3.10. CMake 4 makes this a deprecation warning, which -Werror=dev turns into an error and stops the configure step. CMAKE_WARN_DEPRECATED cannot suppress it because CMP0218 ignores that variable, so raise the policy floor for the subproject instead. Also set CATCH_VERSION, which all the Catch status messages report. Assisted-by: ClaudeCode:claude-opus-5
henryiii
force-pushed
the
feat/fetchcontent
branch
from
July 27, 2026 16:20
0c774fc to
dbda0b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CMake >= 3.24 supports automatic fallback mechanism of
find_package->FetchContent. This is better both for the upstream maintenance and CI, as well as for downstream packagers.Suggested changelog entry:
PYBIND11_CATCH_TESTSandPYBIND11_EIGEN_TESTSCMake optionsfind_package->FetchContentfallback for third-party dependencies when available (CMake >= 3.24). TheDOWNLOAD_*options are deprecated in favor of usingPYBIND11_*_TESTSand standardFETCH_CONTENT_*options to control this