You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@pvlib/pvlib-core please review any PRs that interest you. I volunteer to solicit reviewers for PRs that don't attract attention on their own over the next couple weeks.
Assuming nobody objects, I'll plan to merge #1183 and #1682 tomorrow (March 17) and proceed with making the release. The other PRs in the list above are not ready yet, I think.
What about #1687 in 0.9.5? It's currently marked for 0.10, but @mikofski and the contributor are resolving merge conflicts in 0.9.5, so there's some misaligned expectations. I am -1 on 0.9.5 given the lack of consensus on if it's a good idea and, from a quick look, a need to improve consistency with pvlib style (variable names, positional vs keyword args).
Activity
cwhanse commentedon Mar 2, 2023
I will submit to close #1586
adriesse commentedon Mar 2, 2023
Based on the latest comments, I would not wait for #1658.
kandersolar commentedon Mar 16, 2023
Assuming nobody objects, I'll plan to merge #1183 and #1682 tomorrow (March 17) and proceed with making the release. The other PRs in the list above are not ready yet, I think.
cwhanse commentedon Mar 16, 2023
I'm working on #1666 but computing the known solution for the test case is tedious. I wouldn't wait.
adriesse commentedon Mar 16, 2023
I'd like to have #1695 included, it there are no objections.
mikofski commentedon Mar 16, 2023
If we wait on #1666, then I'd like to push another release as soon as possible after this one. A hot fix.
mikofski commentedon Mar 16, 2023
@kanderso-nrel oops sorry, I merged it already 🤷
wholmgren commentedon Mar 17, 2023
What about #1687 in 0.9.5? It's currently marked for 0.10, but @mikofski and the contributor are resolving merge conflicts in 0.9.5, so there's some misaligned expectations. I am -1 on 0.9.5 given the lack of consensus on if it's a good idea and, from a quick look, a need to improve consistency with pvlib style (variable names, positional vs keyword args).
cwhanse commentedon Mar 17, 2023
I marked #1687 for v0.10 because the comments indicate a lack of consensus.
mikofski commentedon Mar 17, 2023
I agree, let's push #1687 to v0.10. I'll communicate with contributor