Implement registry version check script - #786
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-019f8b54-076c-701a-863f-75106cd6f5bd Co-authored-by: Thomas Honeyman <admin@thomashoneyman.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019f8b54-076c-701a-863f-75106cd6f5bd Co-authored-by: Thomas Honeyman <admin@thomashoneyman.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019f8b91-2aa1-72c0-9046-7862234646fd Co-authored-by: Thomas Honeyman <admin@thomashoneyman.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019f8b91-2aa1-72c0-9046-7862234646fd Co-authored-by: Thomas Honeyman <admin@thomashoneyman.com>
83fb1c3 to
7c1e2cc
Compare
|
This is cool - two things come to mind:
|
|
Yeah, I agree. I don't have a specific policy in mind but directionally I'm on board. To what degree should that be encoded into this script's report? We could augment this with more data than it currently gives. |
|
Also, we could extend this with a planner that makes it more obvious whether the discovered versions will even work together and suggest a batch. Something like:
For this batch, this would have discovered the 14 packages that work without me having to do a separate manual triage:
...this doesn't help with what you're describing, but maybe we can re-think this script such that it's a more useful swiss-army-knife for helping get the package sets updated with the best options when it can't be done automatically due to breaking changes. |
I to get us a good glance we could have:
Also I think we could be running this in a weekly cronjob thing in the Registry repo, opening an issue/PR if it finds something |
|
d283822 has some followups that address your points:
Tried it out with a live run against package set |
|
Latest commit is a prototype, still hacking on it a little. But as I was working on the version check script, I realized we could be doing a lot more automatically — and still safely — to update the package sets. Our current automatic upgrade is basically just "try all new packages in the last 24hrs, and if any fail, go sequentially and only include ones which succeed." Very naive, and if a package doesn't work in its 24h window for whatever reason it is never retried — even if it would work later on (such as a dependency finally upgrading). So the new prototype implements one shared planner that can be used by both the package set updater and the version check workflow. Any version of a package that's already in the set which is newer than what's in the set is eligible for any new plan, plus recently uploaded packages even if they've never been in the set. We restrict to a single compiler version but otherwise ignore ranges. We still try all packages first, but then we do bounded best-first latest/intermediate/current searches. The package set updater, if it is capable of finding a nonempty addition/upgrade plan, can just submit it. If it finds removals, downgrades, etc. then we can have that notify trustees for action, but it will never be automatically done. |
Closes #426 by adding a
.#version-checkscript to report registry versions newer than the versions in the latest package set. This reuses the package set updater candidate traversal instead of being brand-new.I ran the script against package set
77.13.1and found 19 pending versions. Not all of them can compile together, but 14 of them do, and that's submitted as purescript/registry#560.Five versions were intentionally left out:
barlow-lens@1.0.0breaksmorello@0.4.0, which uses the old Barlow API and declares<0.10.0.elmish@0.14.0breakselmish-hooks@0.11.0; meanwhile,elmish-html@0.12.0requires Elmish 0.14, so neither Elmish candidate can move until the dependent packages are compatible.hyrule@2.4.0removes modules still imported bybolson@0.3.9,deku@0.9.24, andocarina@1.5.4.node-child-process@12.0.0changes the exit API and breaksdotenv@4.0.3andnode-execa@5.0.0.So this is the point of the script: surface upgrades that automatic daily updates could not accept so maintainers can identify and submit a compatible coordinated batch.