Repository navigation
(maint) Fix nightly puppet gem install on Windows bundler step - #47
Merged
Merged
Conversation
The Windows x64-mingw build of puppet is only published via Puppet's nightly download infra, never to the artifactory rubygems mirror used as GEM_SOURCE. The module Gemfile also pins puppet to an explicit :source, so Bundler only ever fetches that gem from the declared remote and 404s trying to redownload a version that was already installed locally in the previous step. Extract the downloaded nightly gem into a plain directory with its gemspec alongside it, and point PUPPET_GEM_VERSION at that directory via a file:// URL. The Gemfile's location_for helper treats a file:// value as a path: source and drops the :source pin entirely, so Bundler resolves puppet locally instead of talking to GEM_SOURCE. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
Author
|
Verified that this worked successfully on the augeas gem here: https://github.com/puppetlabs/puppetlabs-augeas_core/actions/runs/36767646031/job/110065740811 |
joshcooper
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
x64-mingwbuild of the nightly puppet gem is only published via Puppet's nightly download infra, never to the artifactory rubygems mirror used asGEM_SOURCE. Consuming module Gemfiles also pinpuppetto an explicit:source, so Bundler only ever fetches that gem from the declared remote — it 404s trying to redownload a version that was already installed locally in the previous step.PUPPET_GEM_VERSIONat that directory via afile://URL. The module Gemfile'slocation_forhelper already treats afile://value as apath:source and drops the:sourcepin entirely, so Bundler resolvespuppetlocally instead of talking toGEM_SOURCE.PUPPET_GEM_VERSIONvalue since PowerShell's parser chokes on the unquoted//and tries to invoke it as a command; bash handles it fine unquoted, but quoting works identically under both shells.Test plan
PATHsource (via the samelocation_forhelper used in module Gemfiles) instead of contacting a pinned:source, using a minimal reproduction Gemfile.puppetlabs/puppetlabs-augeas_corepointed at this branch — nightly Windows unit test job passed.