Improve content_ids handling by defered loading - #7867
Open
mdellweg wants to merge 1 commit into
Open
Conversation
mdellweg
force-pushed
the
content_ids_sql
branch
from
July 24, 2026 15:15
10d9549 to
0324f58
Compare
mdellweg
marked this pull request as ready for review
July 24, 2026 15:15
mdellweg
force-pushed
the
content_ids_sql
branch
from
July 27, 2026 08:32
0324f58 to
be754c7
Compare
pedro-psb
reviewed
Jul 28, 2026
pedro-psb
left a comment
Member
There was a problem hiding this comment.
I was having a look into this, I think we could avoid hydrating content_ids for other methods as well, like added, removed and contains.
mdellweg
force-pushed
the
content_ids_sql
branch
from
July 29, 2026 09:27
be754c7 to
bad7241
Compare
The array_field can be huge and most of the time we don't need the values in python. Some uses can even be handled by clever SQL without ever channelling all the data through the network.
mdellweg
force-pushed
the
content_ids_sql
branch
from
July 29, 2026 10:46
bad7241 to
7c3b937
Compare
4 tasks
|
We have some overlapping changes here... Would you prefer that you merge this in first and then I rebase on the changes or should I undo my changes related to the deferment and have you rebase instead? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The array_field can be huge and most of the time we don't need the values in python. Some uses can even be handled by clever SQL without ever channelling all the data through the network.
📜 Checklist
See: Pull Request Walkthrough