Use separate serializer for token create response - #49
Closed
dralley wants to merge 1 commit into
Closed
Conversation
dralley
force-pushed
the
separate-create-serializer
branch
from
July 29, 2026 18:09
eaeeba0 to
8663254
Compare
Split CargoTokenSerializer into a base serializer (without token field) for list/retrieve and a CargoTokenCreateResponseSerializer (with token) for create responses. This avoids exposing an always-null token field in the list schema and produces more accurate OpenAPI bindings. Assisted-By: Claude Opus 4.6
dralley
force-pushed
the
separate-create-serializer
branch
from
July 29, 2026 18:24
8663254 to
1fc1ea8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split CargoTokenSerializer into a base serializer (without token field) for list/retrieve and a CargoTokenCreateResponseSerializer (with token) for create responses. This avoids exposing an always-null token field in the list schema and produces more accurate OpenAPI bindings.
Assisted-By: Claude Opus 4.6