Skip to content

Enable pulpcore's reclaim disk space feature - #1530

Merged
quba42 merged 1 commit into
pulp:mainfrom
ATIX-AG:enable_reclaim
Sep 16, 2026
Merged

quba42 merged 1 commit into
pulp:mainfrom
ATIX-AG:enable_reclaim

Conversation

@quba42

@quba42 quba42 commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

Entirely untested.

Regarding test coverage:

pulp_rpm does not have any tests for this, relying entirely on pulpcore to do the right thing.

If we do decide to add a test, I would like to see the following:

  • Sync repo A with (at least) packages a and b.
  • Sync repo B with (at least) packages b and c. (b must be checksum identical for both repos)
  • Call reclaim space for repo A.
  • Assert that the artifact for package a is gone.
  • Assert that the artifacts for package b and c are not gone.
  • (optional) Download package a and check that the artifact is back (I believe it should have been turned into a remote/on_demand artifact).

@quba42
quba42 marked this pull request as ready for review September 15, 2026 14:30
@quba42

quba42 commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator Author

Tested this manually. Reclaim of both on_demand and immediate synced repos works as expected. Reclaimed content can still be consumed on_demand as expected.

We discussed we are happy with the tests in pulpcore just like pulp_rpm is.

@hstct hstct left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pipeline failures for the cloud providers are likely unrelated. So change itself looks good

@quba42
quba42 merged commit b54b330 into pulp:main Sep 16, 2026
22 of 27 checks passed
@quba42 quba42 added the .feature CHANGES/<issue_number>.feature label Sep 16, 2026
@quba42
quba42 deleted the enable_reclaim branch September 16, 2026 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

.feature CHANGES/<issue_number>.feature no-issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants