Skip to content

Handle architecture all in repository modify - #1522

Merged
quba42 merged 1 commit into
pulp:mainfrom
daviddavis:fix-architecture-all-repository-modify
Sep 10, 2026
Merged

Handle architecture all in repository modify#1522
quba42 merged 1 commit into
pulp:mainfrom
daviddavis:fix-architecture-all-repository-modify

Conversation

@daviddavis

Copy link
Copy Markdown
Contributor

Summary

  • Repository modify previously accessed an unassigned/stale ReleaseArchitecture for Architecture: all.
  • It now only adds ReleaseArchitecture content for concrete architectures while retaining PackageReleaseComponent.

Testing

  • oci-env test -p pulp_deb functional -k test_repository_modify -vv
  • Result: 12 passed, 1 skipped

Context

Assisted By: GitHub Copilot

Architecture-independent packages need a component relationship but no ReleaseArchitecture.

ref pulp#1492
Assisted By: GitHub Copilot
@quba42 quba42 added .bugfix CHANGES/<issue_number>.bugfix backport-3.11 labels Sep 10, 2026

@quba42 quba42 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review all looks good. (Only add the architecture to the add_content_units list if we actually entered the if block that picks out an architecture, duh!).

The test looks right code wise and I checked it fails without the fix.

@quba42
quba42 merged commit 5a66fd6 into pulp:main Sep 10, 2026
14 checks passed
@patchback

patchback Bot commented Sep 10, 2026

Copy link
Copy Markdown

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/5a66fd68e59e581111440cae79c49842705eea04/pr-1522

Backported as #1527

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

quba42 added a commit that referenced this pull request Sep 11, 2026
…59e581111440cae79c49842705eea04/pr-1522

[PR #1522/5a66fd68 backport][3.11] Handle architecture all in repository modify
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-3.11 .bugfix CHANGES/<issue_number>.bugfix no-issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants