fix: use head-based manifest version check - #2429
Draft
am9zZWY wants to merge 1 commit into
Draft
Conversation
Assisted By: Claude Sonnet 5
am9zZWY
marked this pull request as draft
July 24, 2026 14:18
gerrod3
requested changes
Jul 29, 2026
gerrod3
left a comment
gerrod3
left a comment
Contributor
There was a problem hiding this comment.
Nice work! Can you rebase with main and do a ruff format && ruff check?
Comment on lines
+1
to
+4
| Pull-through manifest resolution now performs a HEAD-based version check and serves locally | ||
| stored manifests without downloading the manifest body. Per Docker Hub's pull definition, version | ||
| checks do not count toward rate limits, substantially reducing 429 errors for repeat tag | ||
| resolutions. |
Contributor
There was a problem hiding this comment.
Can you put this on one line and make it more concise?
Contributor
There was a problem hiding this comment.
Not sure we need a unit test for this fix. As long as the functional tests pass, I think we are fine. The change uses the same pattern as sync, so I'm confident it'll work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Checklist
See: Pull Request Walkthrough