Missed a spot for the PEP-625 fix. - #989
Closed
ggainey wants to merge 1 commit into
Closed
Conversation
pedro-psb
previously approved these changes
Oct 21, 2025
ggainey
force-pushed
the
pep_625_2
branch
2 times, most recently
from
October 21, 2025 12:32
f987f65 to
af2509a
Compare
pedro-psb
reviewed
Oct 21, 2025
| rm -rf "{{ plugin.name | snake }}-client" | ||
| rm -rf "{{ plugin.name | snake }}_client" | ||
|
|
||
| ./gen-client.sh "../{{ plugin_name }}/{{ plugin.app_label }}-api.json" "{{ plugin.app_label }}" python "{{ plugin.name | snake }}" |
Member
There was a problem hiding this comment.
The pulp-openapi-generator generates the client code in a dir named "{{ plugin.name | snake }}-client". Here.
I'm not saying we must update it there, because I understand that the problem is with the python built artifact (source distribution tar) name. And I don't think this dir name affects the artifact name, I don't know.
Anyway, those are two different things.
Contributor
|
As a debugging step it might be useful to |
Contributor
Author
|
On hold - prob will close in favor of #990 |
ggainey
marked this pull request as draft
October 21, 2025 18:09
Contributor
Author
|
#990 works great - closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.