Skip to content

Promote the gh SSH Protocol Opt-In READMEs to Main - #2645

Merged
ptr727 merged 1 commit into
mainfrom
develop
Oct 9, 2026
Merged

ptr727 merged 1 commit into
mainfrom
develop

Conversation

@ptr727

@ptr727 ptr727 commented Oct 9, 2026

Copy link
Copy Markdown
Owner

Promotes the one change develop holds over main: the Linux and Windows host setup READMEs now name the gh SSH protocol opt-in (--gh-ssh-protocol, -GhSshProtocol), covering that the protocol is reported by default, set only on the opt-in, and left unset with a warning where gh is absent or not logged in (#2644).

Fixes #2590

🤖 Generated with Claude Code

Adds a paragraph to `host-setup/linux/README.md` "GitHub Setup" and to
`host-setup/windows/README.md` naming the gh SSH protocol opt-in
(`--gh-ssh-protocol`, `-GhSshProtocol`): reported by default, set only
on the opt-in, and a warning with nothing set where gh is absent or not
logged in. Wording checked against both setup-github scripts and
`docs/host-setup.md` "GitHub CLI".

Closes on promotion: #2590

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings October 9, 2026 10:46
@coderabbitai

coderabbitai Bot commented Oct 9, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Repository: ptr727/ProjectTemplate/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 49a2fece-d4a7-45a0-a0b4-a0a8e8ae326a

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Both documentation additions match the existing setup behavior, and no issues were identified.

0 open findings

What changed in this PR

This promotion brings the gh SSH protocol opt-in documentation from develop to main in both host-setup READMEs.

Changes:

  • Explain that setup reports the protocol by default and changes it only when the opt-in is used.
  • Note that the opt-in warns and sets nothing if gh is missing or not logged in.
File Description
host-setup/​windows/​README.md Documents -GhSshProtocol and its prerequisites.
host-setup/​linux/​README.md Documents --gh-ssh-protocol and its prerequisites.

🧠 Review effort: Lite


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@codecov

codecov Bot commented Oct 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.34%. Comparing base (328de78) to head (e213d64).
⚠️ Report is 347 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2645   +/-   ##
=======================================
  Coverage   59.34%   59.34%           
=======================================
  Files          16       16           
  Lines        8282     8282           
=======================================
  Hits         4915     4915           
  Misses       3367     3367           
Flag Coverage Δ
python-3.13 59.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mention the gh SSH Protocol Opt-In in the Host Setup READMEs

2 participants