Repository navigation
Fix loose-object reads with Dulwich 1.2.10 - #22
Merged
Merged
Conversation
ctoth
marked this pull request as ready for review
October 20, 2026 20:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quire can write a valid loose blob and then fail to read it after reopening the repository with Dulwich 1.2.9. An 8,182-byte payload passes, while 8,183 and 200,000 bytes raise
zlib.error: object header exceeds maximum sizethroughGitStore.read_file. Native Git reads those same disk-backed objects successfully.Require and lock Dulwich 1.2.10, which contains the upstream loose-object header parsing fix. Add a three-case public disk-store regression that verifies the loose object exists, closes the repository, reopens it and reads its contents. No production Python changes or unrelated dependency updates. Existing PR #8 remains untouched.
Validation:
tests/test_git_store.py— 52 passed on Python 3.13.15.Draft for independent review. Task evidence and exact reproduction commands are in
agent-notes/fix-dulwich-loose-object-reading.md.