Repository navigation
Transport finite self-referencing family batches with typed refs - #20
Merged
Merged
Conversation
ctoth
marked this pull request as ready for review
October 20, 2026 05:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self-referencing family rows need their targets' result identities before their references can be rewritten. Add
FamilyInstanceMap.transport_familyfor an explicit finite document batch: plan affected family-owned identities through the declared incoming self-reference graph, then run the existing validated row transport with the complete image map. Cycles and unchanged-external-reference referrers work without recursive hashes or an iteration limit. An identity operation inconsistent with the resolved self references fails the existing single-image check.Add
FamilyDefinition.ref_from_documentfor flat identity placement. It constructs the actual typed reference through the placement's declared factory, so a consumer can prepare transported documents without assuming references are strings. No codec, storage format, hash policy or commit/ref behavior changes.Validation: 18 focused owner tests passed, including all orderings of a mutual cycle, self-loop, referrer closure, unchanged objects/IDs, dangling source rejection, incompatible identity rejection and real typed-ref store preparation. Propstore's 35 focused consumer regressions also passed using this source. Full matrix CI supplies lint/typecheck/tests/build verification.
Supports the separate Propstore #303 coreference transport slice. Leave draft for independent review; no consumer semantics are implemented here.