Repository navigation
Correct five paper-derived implementation contracts - #109
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five implementations still encoded contracts contradicted by the original paper page images reviewed for #108. This series corrects each implementation in its own commit and updates the existing tests and documentation that asserted the same incorrect behavior.
6a2a33a: revised impact removes external attacks entering the influencing set; target-preserving deletion removes edges incident to every member of that set. The existing self-attack example now expects negative impact.d308240: PAF distance charges 0.5 for ignorance versus a definite relation and 1 for attack versus non-attack, including float objective annotations.152277f: consensual expansion imports the full profile's uncontested relations while preserving the source's commitments. API change:consensual_expansionnow takes the profile as its second argument; repository callers and docs are updated.4682283: AF change classification uses the paper's extension-family cardinalities and quantifiers, including decisive precedence and the equal-count requirement for expansive changes.c56d764: transposition closure retains seed rules and generated transpositions, including contradictory antecedents and conclusions already among the antecedents. Unsupported pruning and the corresponding false test invariant are removed.Evidence: original page images only, for AlAnaissy 2024 pp. 1, 3–4; Coste-Marquis 2007 pp. 6–10; Cayrol et al. (2010 publication in the local 2014 directory) pp. 6, 8–11; and Prakken 2010 p. 12. No PDF text extraction or OCR was used.
Existing assertions and generators are corrected; no new test functions or guards are added. The argument builder's existing restriction to non-repeating conclusion paths remains a limitation outside this series; the existing nontriviality property now states that restriction explicitly.
Validation runs in this PR's existing Python 3.11/3.14 workflow. No local CI steps were run. This PR is left open for review.