feat: add option to exclude specific default metrics from collection#689
Open
kwaszczuk wants to merge 2 commits into
Open
feat: add option to exclude specific default metrics from collection#689kwaszczuk wants to merge 2 commits into
kwaszczuk wants to merge 2 commits into
Conversation
jdmarshall
approved these changes
Jul 4, 2026
jdmarshall
left a comment
jdmarshall
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
@zbjornson @SimenB how do we feel about this one?
jdmarshall
requested changes
Jul 4, 2026
jdmarshall
left a comment
jdmarshall
left a comment
Contributor
There was a problem hiding this comment.
Needs a changelog entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #623 (I believe it was incorrectly marked as fixed)
This PR adds
excludeoption to theDefaultMetricsCollectorConfigurationthat allows to omit certain group of metrics from being collected.My own use case is that I use a custom implementation of
eventLoopLagmetrics (though based on the original one), so I need to exclude them to avoid conflicts in registry, but others may want to also use it to remove redundant and unused metrics.An alternative approach would be to expose the exports from
lib/metricsin the public interface, allowing users to import and manually register only the specific metrics they need. I’m not sure, though, which approach is better - this one or theexcludeapproach.