chore: real ESLint setup across workspace, dedupe CI test workflow#16
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
|
Reviewed both Socket alerts - both look like false positives from added devDependencies, not actual risk: @typescript-eslint/eslint-plugin@8.62.0 - "obfuscated code" @humanfs/types@0.15.0 - "low adoption" |
Fixed everything the new linter caught:
i) removed dead code in scripts/set-version.mjs (unused groups array, duplicated literal)
disambiguated two regex literals in scripts/submit-packages.mjs per no-regex-spaces (verified byte-identical matching behavior - no functional change)
ii) added a scoped suppression for an intentional NUL-sentinel-byte regex in markdown.js (real technique for protecting inline code spans, not a bug)
iii) renamed one genuinely-unused catch (e) binding to _e in options.js
Verified locally (Node 24, pnpm 9.12.0): all 22 packages lint clean (warnings only - pre-existing any usage in services/api and one pre-existing stale eslint-disable in coinpay-oauth.ts, both left untouched as out of scope), pnpm typecheck passes, pnpm test passes.