Skip to content

fix(cli): ignore string braces when editing targets - #1004

Open
hamedrabah wants to merge 1 commit into
profullstack:masterfrom
hamedrabah:fix-target-config-brace-parsing
Open

fix(cli): ignore string braces when editing targets#1004
hamedrabah wants to merge 1 commit into
profullstack:masterfrom
hamedrabah:fix-target-config-brace-parsing

Conversation

@hamedrabah

Copy link
Copy Markdown

Summary

  • mask string and comment contents before locating the targets object boundary
  • keep newly added targets at the top level when existing config values contain braces
  • add a regression test that reloads the edited manifest and verifies the target is enabled

Tests

  • pnpm exec vitest run packages/cli/src/commands/ship.test.ts
  • pnpm --filter @profullstack/sh1pt typecheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant