fix(release): stop reporting a gated Chrome publish as success - #25
Merged
Conversation
The Chrome job caught the 'Publish condition not met' error, downgraded it to a warning and exited 0. The run went green, the version was never submitted, and the store quietly kept serving an older build — v0.8.37 and v0.8.39 both sat as unsubmitted drafts this way. Chrome invalidates the permission justifications whenever the manifest's permission set changes, so this fires on most releases that touch permissions. The gate now fails the job with the dashboard steps in the error, and each store writes its real outcome to the run summary so a green tick is no longer the only signal. Adds a daily Verify Published Versions workflow that asks the Chrome update server and AMO what they actually serve and fails when Chrome trails the newest tag, plus docs/CHROME_PRIVACY_PRACTICES.md with ready-to-paste justifications for every permission in the manifest. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MrHcQXSjCeCcAKhWPZg8w9
ThreatCrush Security Scan12 finding(s) MEDIUM: 8 | LOW: 4
Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug
The Chrome publish step caught
Publish condition not met, downgraded it to a::warningandexit 0. The run went green, the version was never submitted, and the store kept serving an older build.Both v0.8.37 and v0.8.39 sat as unsubmitted drafts this way. Right now the Chrome update server serves 0.8.38 while 0.8.39 is tagged and CI says success.
Chrome invalidates the permission justifications whenever the manifest's permission set changes, so this fires on most releases that touch permissions — it is not a one-time account gate.
Changes
$GITHUB_STEP_SUMMARY, so a green tick is no longer the only signal. Edge's dead credentials now show as "nothing shipped" rather than passing silently.Verify Published Versionsworkflow (daily + manual) asks the Chrome update server and AMO what they actually serve, and fails when Chrome trails the newest tag.docs/CHROME_PRIVACY_PRACTICES.md— ready-to-paste justifications for every permission and host in the manifest, plus the steps to clear the gate.Checks
version="pattern matched the XML declaration'sversion="1.0". Now anchored to the<updatecheck>element.Note
The new workflow will go red on its first run. That is correct — Chrome is behind, and stays behind until the Privacy practices form is completed in the dashboard. Merging this does not publish 0.8.39; nothing automated can.
🤖 Generated with Claude Code
https://claude.ai/code/session_01MrHcQXSjCeCcAKhWPZg8w9