fix(release): the version bump skipped a package, and would again - #17
Merged
Conversation
`packages/fleet-core` was added and never listed in MANIFESTS, so the next
release would have bumped seven manifests and left it on 0.2.7 — quietly,
because the drift check that exists to catch exactly this only looks at what
is already listed. It cannot report a package it was never told about.
So: list it, and stop the list from being the weak point. The release now
discovers every workspace package under apps/ and packages/ and refuses to
run when one is missing, alongside the other guards that all fire before
anything is written.
these workspace packages are not listed in MANIFESTS in scripts/release.mjs:
packages/fleet-core/package.json
Add them, or the release leaves them behind at an old version.
Verified both directions: the guard is silent on the tree as it stands, and
refuses when fleet-core is removed from the list again.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UeSWg1Czsb2Lwxj8vHUnA4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
packages/fleet-corelanded in #16 and was never added toMANIFESTSinscripts/release.mjs. The next release would have bumped seven manifests and left it on0.2.7— silently, because the drift check that exists to catch exactly this only inspects manifests that are already listed. It cannot report a package it was never told about.So this does two things:
packages/fleet-core/package.json.apps/andpackages/and refuses when one is unlisted, alongside the other guards that all fire before anything is written.Verified
Both directions, by running the discovery against the real tree:
packages/fleet-coredeleted from the list again — guard refuses and names it.The existing guards still fire in order (
working tree is dirtybefore the branch check, and so on), so nothing about the refusal sequence changed.Worth cutting the next release with this in. Without it,
fleet-coredrifts a version further behind at every release, and the moment anyone does add it to the list, the drift guard blocks the release until the versions are reconciled by hand.🤖 Generated with Claude Code
https://claude.ai/code/session_01UeSWg1Czsb2Lwxj8vHUnA4