Repository navigation
V2 upgrade skill - #619
Open
jhollinger wants to merge 4 commits into
Open
V2 upgrade skill#619jhollinger wants to merge 4 commits into
jhollinger wants to merge 4 commits into
Conversation
jhollinger
force-pushed
the
jh/release-2.0-upgrade-skill
branch
from
October 29, 2026 17:52
dd2669f to
8a1440e
Compare
jhollinger
force-pushed
the
jh/release-2.0-upgrade-skill
branch
2 times, most recently
from
November 2, 2026 16:56
f37b25f to
6d29bef
Compare
jhollinger
force-pushed
the
jh/release-2.0-upgrade-skill
branch
from
November 4, 2026 22:15
6fdbf96 to
41e5753
Compare
jhollinger
marked this pull request as ready for review
November 4, 2026 22:25
…ure it's distributed with the gem Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
Replace the branch-heavy config/feature checks in inventory.rb with lookup tables, split describe_field and describe_views, and extract snapshot.rb's per-fixture work out of run. Exclude skills/ from Metrics/ClassLength and Metrics/ModuleLength only. These are single-file programs meant to be run standalone inside a user's app, so splitting them across files to satisfy a size cop would defeat the point. Every other cop still applies. Verified the refactors are behavior-preserving: inventory.rb reports the same version, config notes, and per-Blueprint v1_features, and the V1 -> V2 snapshot comparison is still 13/13 identical under --strict-order with the error-counting path intact. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
jhollinger
force-pushed
the
jh/release-2.0-upgrade-skill
branch
from
November 5, 2026 02:09
c073b53 to
36feeff
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an upgrade skill that will be included in the gem. Works for partial (e.g. specific blueprints) or a full upgrade. This will need more testing and refinement, but I think it's a good start.