Repository navigation
V2: Misc fixes and gotchas - #618
Merged
Merged
Conversation
jhollinger
force-pushed
the
jh/release-2.0-misc-fixes
branch
2 times, most recently
from
October 29, 2026 15:13
a098202 to
c610c56
Compare
jhollinger
marked this pull request as ready for review
October 29, 2026 15:34
Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
V2 now behaves like V1: if `default_if` is present, that's the only factor in deciding to use `default`. Otherwise it's a nil check. Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
Struct includes Enumerable, so `render` was routing Structs through `render_collection` and iterating their members. The collection heuristic now lives in `V2::Rendering::NON_COLLECTIONS` and the shared `V2::Rendering.collection?` predicate, which AssociationExtractor's V1-to-V2 bridge uses too (it had its own copy of the old check). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
…p and one less allocation per field Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
jhollinger
force-pushed
the
jh/release-2.0-misc-fixes
branch
from
November 4, 2026 22:08
500cedd to
8edf324
Compare
Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
jhollinger
force-pushed
the
jh/release-2.0-misc-fixes
branch
from
November 4, 2026 22:12
78c2e41 to
4b70a07
Compare
lessthanjacob
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While developing a V1-V2 migration skill, I (Claude) found several bugs and gotchas. This PR fixes or improves them in bulk:
formatrespect child classes, which is probably what users would expect.default_ifbehavior.LegacyOptionswith respect to V1's actual behavior.LegacyDynamicOptions.rendernow treatsStructas an object instead of a collection.docs/v2.